zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #102: ZOOKEEPER-2628: Fix findbug warnings.
Date Wed, 23 Nov 2016 16:58:39 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/102
  
    @fpj Thank you for taking time to double check the patch.
    
    >> I noticed that there are also unaddressed comments from @lvfangmin and @eribeiro
.
    The comments were about using Interface type instead of implementation type, and I addressed
the comments by creating ZOOKEEPER-2630 because this issue is not a regression and is not
specifically about findbug warnings, and I think it might be better to address them separately.
    
    I've left replies on your other comments in PR, please take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message