zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fpj <...@git.apache.org>
Subject [GitHub] zookeeper pull request #102: ZOOKEEPER-2628: Fix findbug warnings.
Date Wed, 23 Nov 2016 10:13:57 GMT
Github user fpj commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/102#discussion_r89283699
  
    --- Diff: src/java/main/org/apache/zookeeper/cli/DeleteCommand.java ---
    @@ -56,14 +56,7 @@ public CliCommand parse(String[] cmdArgs) throws CliParseException
{
         }
     
         private void retainCompatibility(String[] cmdArgs) throws CliParseException {
    -        // delete path [version]
             if (args.length > 2) {
    -            // rewrite to option
    -            String [] newCmd = new String[4];
    --- End diff --
    
    Why are we removing this rewrite?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message