zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fpj <...@git.apache.org>
Subject [GitHub] zookeeper pull request #84: [ZOOKEEPER-1525] Plumb ZooKeeperServer object in...
Date Tue, 15 Nov 2016 06:57:39 GMT
Github user fpj commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/84#discussion_r87957495
  
    --- Diff: src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
    @@ -543,7 +546,7 @@ protected void pRequest2Txn(int type, long zxid, Request request,
                     }
                     
                     nodeRecord = getRecordForPath(ZooDefs.CONFIG_NODE);               
    -                checkACL(zks, nodeRecord.acl, ZooDefs.Perms.WRITE, request.authInfo);
                 
    +                checkACL(zks, request.cnxn, nodeRecord.acl, ZooDefs.Perms.WRITE, request.authInfo,
"/", null);
    --- End diff --
    
    `null` tells me that the method is not expecting a value from the caller in that position,
which is better than an arbitrary value. I think it is fine to change it to `null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message