zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Han <h...@cloudera.com>
Subject Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster
Date Fri, 04 Nov 2016 16:32:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51546/
-----------------------------------------------------------

(Updated Nov. 4, 2016, 4:32 p.m.)


Review request for zookeeper, fpj, Patrick Hunt, Raul Gutierrez Segales, and Alexander Shraer.


Changes
-------

Address Ben's comment by replacing KeeperException.NoNodeException with RuntimeException in
addConfigNode to avoid changing function signatures across code base.


Bugs: ZOOKEEPER-2014
    https://issues.apache.org/jira/browse/ZOOKEEPER-2014


Repository: zookeeper-git


Description
-------

Address various security concerns around reconfig feature (ZOOKEEPER-2014) to unblock 3.5.3
release.


Diffs (updated)
-----

  build.xml 5328035 
  src/c/include/zookeeper.h 18a203d 
  src/c/tests/TestReconfigServer.cc 6a429ac 
  src/c/tests/ZooKeeperQuorumServer.h aa8b7cc 
  src/c/tests/ZooKeeperQuorumServer.cc 23392cd 
  src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 5a30da8 
  src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml 7168a01 
  src/java/main/org/apache/zookeeper/ClientCnxn.java 12dd51c 
  src/java/main/org/apache/zookeeper/KeeperException.java a05f1ab 
  src/java/main/org/apache/zookeeper/ZooKeeper.java 1c9ed4e 
  src/java/main/org/apache/zookeeper/ZooKeeperMain.java c39395a 
  src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/cli/CliCommand.java 3d0a90b 
  src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java deb7914 
  src/java/main/org/apache/zookeeper/server/DataTree.java 4666578 
  src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e275f9c 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java d4f150b 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 885a5e1 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 24a4ec1 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java.orig PRE-CREATION

  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java bfe8588 
  src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 109c1b5 
  src/java/test/org/apache/zookeeper/TestableZooKeeper.java 4d46fdf 
  src/java/test/org/apache/zookeeper/server/DataTreeTest.java d726643 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 4debe74 
  src/java/test/org/apache/zookeeper/server/quorum/RaceConditionTest.java ef7f3df 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java 241af52 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigDuringLeaderSyncTest.java 301837d

  src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java e7147b3 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java 37bd8e4 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java.orig PRE-CREATION

  src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java 1f6ce1f 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 6a01447 
  src/java/test/org/apache/zookeeper/test/ACLTest.java 9920fc4 
  src/java/test/org/apache/zookeeper/test/ClientBase.java 309b2b2 
  src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/ReconfigMisconfigTest.java PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/ReconfigTest.java 248a754 
  src/java/test/org/apache/zookeeper/test/StandaloneTest.java 5c95280 

Diff: https://reviews.apache.org/r/51546/diff/


Testing
-------


Thanks,

Michael Han


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message