zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eribeiro <...@git.apache.org>
Subject [GitHub] zookeeper pull request #98: ZOOKEEPER-2479
Date Thu, 03 Nov 2016 18:41:30 GMT
Github user eribeiro commented on a diff in the pull request:

    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){
         protected boolean quorumListenOnAllIPs = false;
    +     * Keeps time taken for leader election in milliseconds. Sets the value to
    +     * this variable only after the completion of leader election.
    +     */
    +    private long electionTimeTaken = -1;
    --- End diff --
    sincere question: does it make sense to make this field `volatile`? I know there are some
concurrency guarantees but not sure if it's worth change it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message