zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #97: ZOOKEEPER-2624: Add test script for pull request...
Date Thu, 03 Nov 2016 16:25:50 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/97#discussion_r86384484
  
    --- Diff: build.xml ---
    @@ -1622,6 +1623,26 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
         	</exec>
          </target>
     
    +     <target name="qa-test-pullrequest" depends="findbugs.check,forrest.check">
    +        <exec executable="bash" failonerror="true">
    +                <arg value="${test_pullrequest_sh}"/>
    +                <arg value="QABUILD"/>
    +                <arg value="${scratch.dir}"/>
    +                <arg value="${ps.cmd}"/>
    +                <arg value="${wget.cmd}"/>
    +                <arg value="${jiracli.cmd}"/>
    +                <arg value="${git.cmd}"/>
    +                <arg value="${grep.cmd}"/>
    +                <arg value="${patch.cmd}"/>
    +                <arg value="${findbugs.home}"/>
    +                <arg value="${forrest.home}"/>
    +                <arg value="${basedir}"/>
    +                <arg value="${jira.passwd}"/>
    +                <arg value="${java5.home}"/>
    +                <arg value="${curl.cmd}"/>
    --- End diff --
    
    There was a '<arg value="${defect}"/>' in test-patch.sh but missing here - is this
intentionally left out? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message