zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Han (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster
Date Sat, 08 Oct 2016 17:52:20 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15558418#comment-15558418
] 

Michael Han commented on ZOOKEEPER-2014:
----------------------------------------

[~fpj]: This is a flaky test, and it happened before this patch with exact same error message
in Apache builds and precommit build. I did a search over my email archive and found a couple
of instances (e.g. ZooKeeper_branch35_openjdk7 - Build # 159). I'll create a separate JIRA
and put it under ZOOKEEPER-2135.

On a side note, I have an internal Jenkins job that set up and stress test my patch branch
of ZOOKEEPER-2014. There is no test failure except the one that's already tracked in ZOOKEEPER-2080.
So this flaky testQuorumSystemChange one might also hard to reproduce.

> Only admin should be allowed to reconfig a cluster
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-2014
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.0
>            Reporter: Raul Gutierrez Segales
>            Assignee: Michael Han
>            Priority: Blocker
>             Fix For: 3.5.3
>
>         Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch,
ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We should,
at the very least, ensure that only the Admin can reconfigure a cluster. Perhaps restricting
access to /zookeeper/config as well, though this is debatable. Surely one could ensure Admin
only access via an ACL, but that would leave everyone who doesn't use ACLs unprotected. We
could also force a default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run with zookeeper.DigestAuthenticationProvider.superDigest
(which I am not sure if everyone does, or how would it work with other authentication providers).

> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message