zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Ribeiro (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2517) jute.maxbuffer is ignored
Date Thu, 08 Sep 2016 17:37:20 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474512#comment-15474512
] 

Edward Ribeiro commented on ZOOKEEPER-2517:
-------------------------------------------

Nice points, Arshad. LGTM.

> jute.maxbuffer is ignored
> -------------------------
>
>                 Key: ZOOKEEPER-2517
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2517
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.2
>            Reporter: Benjamin Jaton
>            Assignee: Arshad Mohammad
>            Priority: Blocker
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2517-01.patch, ZOOKEEPER-2517-02.patch, ZOOKEEPER-2517.patch
>
>
> In ClientCnxnSocket.java the parsing of the system property is erroneous:
> {code}packetLen = Integer.getInteger(
>   clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER),
>   ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT
> );{code}
> Javadoc of Integer.getInteger states "The first argument is treated as the name of a
system property", whereas here the value of the property is passed.
> Instead I believe the author meant to write something like:
> {code}packetLen = Integer.parseInt(
>   clientConfig.getProperty(
>     ZKConfig.JUTE_MAXBUFFER,
>     String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT)
>   )
> );{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message