zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raul Gutierrez Segales (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2498) Potential resource leak in C client when processing unexpected / out of order response
Date Wed, 03 Aug 2016 18:22:20 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406352#comment-15406352
] 

Raul Gutierrez Segales commented on ZOOKEEPER-2498:
---------------------------------------------------

[~hanm]: thanks! Merged:

https://github.com/apache/zookeeper/commit/21b0152ed0e0841b961ff3bca0b0d3c8567ce1a4
https://github.com/apache/zookeeper/commit/9518d9cb69cf1aaa05194795df3bfd6950b64a04
https://github.com/apache/zookeeper/commit/c00937a34b124fb705febab3422827be4891eb39


> Potential resource leak in C client when processing unexpected / out of order response
> --------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2498
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2498
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.4.8, 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>             Fix For: 3.4.9, 3.5.3
>
>         Attachments: ZOOKEEPER-2498.patch
>
>
> In C client, we use reference counting to decide if a given zh handle can be destroyed
or not. This requires we always make sure to call api_prolog (which increment the counter)
and api_epilog (which decrease the counter) in pairs, for a given call context. 
> In zookeeper_process, there is a place where the code will return without invoking api_epilog,
which would lead to potential zh resource leak.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message