zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2491) C client build error in vs 2015
Date Sun, 28 Aug 2016 20:19:21 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15444052#comment-15444052
] 

Chris Nauroth commented on ZOOKEEPER-2491:
------------------------------------------

bq. perhaps we can just have a separate source file (.h) that includes that comment section
in it's entirety?

This might be a good idea anyway for code organization, but I don't think it removes the requirement
to update the NOTICE file.

bq. fwiw also says "substantial portions of the Software", does a single utility method meet
that bar?

In other projects, we have followed this rule even for a small utility method like this.

bq. On that topic, instead of making a complete copy of code from libUV we could write our
own safer version of snprintf for lower version of MSVC.. would that be a better approach
to get into the license issue?

This is my preferred option.  It's a small enough amount of code that I'd favor writing our
own version of it.

I should qualify this by saying that I don't consider myself an expert on licensing requirements.
 I'm speaking from the viewpoint of past experience on other projects, not authoritative interpretation
of the rules.  If anyone would prefer to dig deeper into it, there is more information here:

http://www.apache.org/dev/licensing-howto.html

If there are still points of confusion, then general@incubator.apache.org is a good place
to get advice on licensing issues.

> C client build error in vs 2015 
> --------------------------------
>
>                 Key: ZOOKEEPER-2491
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.5.2
>         Environment: windows vs 2015
>            Reporter: spooky000
>            Assignee: spooky000
>            Priority: Minor
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message