zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Han (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2491) C client build error in vs 2015
Date Thu, 25 Aug 2016 00:04:20 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435974#comment-15435974
] 

Michael Han commented on ZOOKEEPER-2491:
----------------------------------------

I think we can possibly review and commit the version 2 patch (timestamp 28/Jul/16). This
JIRA is essentially fix a regression caused by new version of MSVC and simulating snprintf
is not a regression as the problem was there before... so we can probably use another JIRA
to track that issue? On that topic, instead of making a complete copy of code from libUV we
could write our own safer version of snprintf for lower version of MSVC.. would that be a
better approach to get into the license issue?

> C client build error in vs 2015 
> --------------------------------
>
>                 Key: ZOOKEEPER-2491
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.5.2
>         Environment: windows vs 2015
>            Reporter: spooky000
>            Assignee: spooky000
>            Priority: Minor
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message