zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Hunt (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (ZOOKEEPER-2491) C client build error in vs 2015
Date Wed, 24 Aug 2016 22:59:21 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435889#comment-15435889
] 

Patrick Hunt edited comment on ZOOKEEPER-2491 at 8/24/16 10:58 PM:
-------------------------------------------------------------------

[~cnauroth] - lubuv is not an apache license. From what I read in the linked file

"The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software."

perhaps we can just have a separate source file (.h) that includes that comment section in
it's entirety?

fwiw also says "substantial portions of the Software", does a single utility method meet that
bar? (regardless I'm hoping we can use the approach I suggest earlier in this comment)


was (Author: phunt):
[~cnauroth] - lubuv is not an apache license. From what I read in the linked file

"The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software."

perhaps we can just have a separate source file (.h) that includes that comment section in
it's entirety?

fwiw also says "substantial portions of the Software", does a single utility method meet that
bar? (regardless I'm hoping we can use the approach I suggest earlier in this comment?

> C client build error in vs 2015 
> --------------------------------
>
>                 Key: ZOOKEEPER-2491
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.5.2
>         Environment: windows vs 2015
>            Reporter: spooky000
>            Assignee: spooky000
>            Priority: Minor
>             Fix For: 3.5.3, 3.6.0
>
>         Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message