Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 53573200B36 for ; Wed, 22 Jun 2016 00:25:02 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 519E0160A60; Tue, 21 Jun 2016 22:25:02 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BE9B3160A63 for ; Wed, 22 Jun 2016 00:25:01 +0200 (CEST) Received: (qmail 30176 invoked by uid 500); 21 Jun 2016 22:24:59 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 29482 invoked by uid 99); 21 Jun 2016 22:24:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Jun 2016 22:24:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 803822C1F70 for ; Tue, 21 Jun 2016 22:24:58 +0000 (UTC) Date: Tue, 21 Jun 2016 22:24:58 +0000 (UTC) From: "Chris Nauroth (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-847) Missing acl check in zookeeper create MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Jun 2016 22:25:02 -0000 [ https://issues.apache.org/jira/browse/ZOOKEEPER-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated ZOOKEEPER-847: ------------------------------------ Fix Version/s: (was: 3.5.2) 3.5.3 > Missing acl check in zookeeper create > ------------------------------------- > > Key: ZOOKEEPER-847 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-847 > Project: ZooKeeper > Issue Type: Bug > Components: java client > Affects Versions: 3.3.1, 3.3.2, 3.3.3 > Reporter: Patrick Datko > Fix For: 3.6.0, 3.5.3 > > Attachments: ZOOKEEPER-847.patch > > > I watched the source of the zookeeper class and I missed an acl check in the asynchronous version of the create operation. Is there any reason, that in the asynch version is no > check whether the acl is valid, or did someone forget to implement it. It's interesting because we worked on a refactoring of the zookeeper client and don't want to implement a bug. > The following code is missing: > if (acl != null && acl.size() == 0) { > throw new KeeperException.InvalidACLException(); > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)