zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abraham Fine <...@abrahamfine.com>
Subject Re: Review Request 49112: ZOOKEEPER-1898
Date Wed, 22 Jun 2016 23:11:11 GMT


> On June 22, 2016, 10:52 p.m., Patrick Hunt wrote:
> > src/java/main/org/apache/zookeeper/ZooKeeperMain.java, line 626
> > <https://reviews.apache.org/r/49112/diff/1/?file=1427805#file1427805line626>
> >
> >     See my comment on the exception class. Should we have more than one exit code,
ie based on the type of exception. I'm not sure if that's valuable, but it seems like it might
be for someone trying to script this?

That is something that may be worth doing but I thought that the work of determining what
that mapping would be (which may involve changing which exceptions are thrown) might have
been outside the scope of this jira. This patch makes it very easy to add this kind of mapping
in the future. Do you think this is something that I should change in this patch?


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49112/#review139157
-----------------------------------------------------------


On June 22, 2016, 10:27 p.m., Abraham Fine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49112/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 10:27 p.m.)
> 
> 
> Review request for zookeeper.
> 
> 
> Bugs: ZOOKEEPER-1898
>     https://issues.apache.org/jira/browse/ZOOKEEPER-1898
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> zookeeper-cli always return "0" as exit code
> 
> 
> Diffs
> -----
> 
>   src/java/main/org/apache/zookeeper/ZooKeeperMain.java f722693 
>   src/java/main/org/apache/zookeeper/cli/CliCommand.java 527a19e 
>   src/java/main/org/apache/zookeeper/cli/CreateCommand.java cc96939 
>   src/java/main/org/apache/zookeeper/cli/DeleteCommand.java 4714be5 
>   src/java/main/org/apache/zookeeper/cli/InvalidCommandException.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/cli/ListQuotaCommand.java 907c466 
>   src/java/main/org/apache/zookeeper/cli/LsCommand.java 43099b8 
>   src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java 282af55 
>   src/java/main/org/apache/zookeeper/cli/RemoveWatchesCommand.java f63cf0f 
>   src/java/main/org/apache/zookeeper/cli/SetAclCommand.java f27446c 
>   src/java/main/org/apache/zookeeper/cli/SetCommand.java 1c39377 
>   src/java/main/org/apache/zookeeper/cli/SetQuotaCommand.java 873c6d2 
>   src/java/test/org/apache/zookeeper/ZooKeeperTest.java 574eab0 
> 
> Diff: https://reviews.apache.org/r/49112/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message