zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Maslyakov <evol...@gmail.com>
Subject Re: [jira] [Commented] (ZOOKEEPER-2422) Improve health reporting by adding heap stats
Date Tue, 03 May 2016 02:32:01 GMT
I struggle to understand how the isolated change to the "mntr" 4lw could
backfire in some seemingly irrelevant unit tests in C code, which does not
even use the "mntr" command. Or am I not reading the log correctly. Any
suggestions? Is there a chance that some other changes were pulled in and
my patch is not the cause of the unit test failure?

This could be an obvious statement but all "ant clean test" passes on my
machine.


Regards,
/Sergey

On Mon, May 2, 2016 at 7:33 PM, Hadoop QA (JIRA) <jira@apache.org> wrote:

>
>     [
> https://issues.apache.org/jira/browse/ZOOKEEPER-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267809#comment-15267809
> ]
>
> Hadoop QA commented on ZOOKEEPER-2422:
> --------------------------------------
>
> -1 overall.  Here are the results of testing the latest attachment
>
> http://issues.apache.org/jira/secure/attachment/12801800/zookeeper-2422-3.6.patch
>   against trunk revision 1742002.
>
>     +1 @author.  The patch does not contain any @author tags.
>
>     +1 tests included.  The patch appears to include 3 new or modified
> tests.
>
>     +1 javadoc.  The javadoc tool did not generate any warning messages.
>
>     +1 javac.  The applied patch does not increase the total number of
> javac compiler warnings.
>
>     +1 findbugs.  The patch does not introduce any new Findbugs (version
> 2.0.3) warnings.
>
>     +1 release audit.  The applied patch does not increase the total
> number of release audit warnings.
>
>     -1 core tests.  The patch failed core unit tests.
>
>     +1 contrib tests.  The patch passed contrib unit tests.
>
> Test results:
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3146//testReport/
> Findbugs warnings:
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3146//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
> Console output:
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3146//console
>
> This message is automatically generated.
>
> > Improve health reporting by adding heap stats
> > ---------------------------------------------
> >
> >                 Key: ZOOKEEPER-2422
> >                 URL:
> https://issues.apache.org/jira/browse/ZOOKEEPER-2422
> >             Project: ZooKeeper
> >          Issue Type: Improvement
> >    Affects Versions: 3.4.8, 3.4.9, 3.5.1, 3.5.2, 3.6.0
> >            Reporter: Sergey Maslyakov
> >             Fix For: 3.4.8, 3.4.9, 3.5.1, 3.5.2, 3.6.0
> >
> >         Attachments: zookeeper-2422-3.4.patch, zookeeper-2422-3.5.patch,
> zookeeper-2422-3.6.patch
> >
> >
> > In order to improve remote monitoring of the ZooKeeper instance using
> tools like Icinga/NRPE, it is very desirable to expose JVM heap stats via a
> light-weight interface. The "mntr" 4lw is a good candidate for this.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message