Return-Path: X-Original-To: apmail-zookeeper-dev-archive@www.apache.org Delivered-To: apmail-zookeeper-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5A3361741C for ; Fri, 1 May 2015 20:34:09 +0000 (UTC) Received: (qmail 96385 invoked by uid 500); 1 May 2015 20:34:09 -0000 Delivered-To: apmail-zookeeper-dev-archive@zookeeper.apache.org Received: (qmail 96339 invoked by uid 500); 1 May 2015 20:34:09 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 96327 invoked by uid 99); 1 May 2015 20:34:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 May 2015 20:34:09 +0000 Date: Fri, 1 May 2015 20:34:08 +0000 (UTC) From: "Hadoop QA (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 14523865#comment-14523865 ]=20 Hadoop QA commented on ZOOKEEPER-1077: -------------------------------------- +1 overall. Here are the results of testing the latest attachment=20 http://issues.apache.org/jira/secure/attachment/12729821/ZOOKEEPER-1077.0= 02.patch against trunk revision 1676359. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tes= ts. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of java= c compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.= 0.3) warnings. +1 release audit. The applied patch does not increase the total number= of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2667/= /testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/= 2667//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/266= 7//console This message is automatically generated. > C client lib doesn't build on Solaris > ------------------------------------- > > Key: ZOOKEEPER-1077 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 > Project: ZooKeeper > Issue Type: Bug > Components: build, c client > Affects Versions: 3.3.4 > Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i8= 6pc i386 i86pc > GNU toolchain (gcc 3.4.3, GNU Make etc.) > Reporter: Tadeusz Andrzej Kad=C5=82ubowski > Assignee: Chris Nauroth > Priority: Critical > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-1077-branch-3.4.002.patch, ZOOKEEPER-1077.= 001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch > > > Hello, > Some minor trouble with building ZooKeeper C client library on Sun^H^H^HO= racle Solaris 5.10. > 1. You need to link against "-lnsl -lsocket" > 2. ctime_r needs a buffer size. The signature is: "char *ctime_r(const ti= me_t *clock, char *buf, int buflen)" > 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cum= bersome ;) ) > 4. getpwuid_r()returns pointer to struct passwd, which works as the last = parameter on Linux. > Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd = *pwd, char *buffer, int buflen);=20 > Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf,= size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)