Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Fri, 1 May 2015 20:18:07 +0000 (UTC)
From: "Chris Nauroth (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.12508402.1306398903000.50389.1430511487173@Atlassian.JIRA>
In-Reply-To: <JIRA.12508402.1306398903000@Atlassian.JIRA>
References: <JIRA.12508402.1306398903000@Atlassian.JIRA>
 <JIRA.12508402.1306398903447@arcas>
Subject: [jira] [Updated] (ZOOKEEPER-1077) C client lib doesn't build on
 Solaris
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated ZOOKEEPER-1077:
-------------------------------------
    Attachment: ZOOKEEPER-1077-branch-3.4.002.patch

Here is the branch-3.4 patch.  There were no changes required in zookeeper.=
c for this one, because the {{MSG_NOSIGNAL}} stuff is handled differently t=
here.  zk_log.c on this branch has an extra conditional for {{WIN32}}.  I d=
idn't bother with casting the pid there, because {{getpid}} on Windows is d=
ocumented to return {{int}}.

https://msdn.microsoft.com/en-us/library/t2y34y40.aspx

> C client lib doesn't build on Solaris
> -------------------------------------
>
>                 Key: ZOOKEEPER-1077
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build, c client
>    Affects Versions: 3.3.4
>         Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i8=
6pc i386 i86pc
> GNU toolchain (gcc 3.4.3, GNU Make etc.)
>            Reporter: Tadeusz Andrzej Kad=C5=82ubowski
>            Assignee: Chris Nauroth
>            Priority: Critical
>             Fix For: 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-1077-branch-3.4.002.patch, ZOOKEEPER-1077.=
001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch
>
>
> Hello,
> Some minor trouble with building ZooKeeper C client library on Sun^H^H^HO=
racle Solaris 5.10.
> 1. You need to link against "-lnsl -lsocket"
> 2. ctime_r needs a buffer size. The signature is: "char *ctime_r(const ti=
me_t *clock, char *buf, int buflen)"
> 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cum=
bersome ;) )
> 4. getpwuid_r()returns pointer to struct passwd, which works as the last =
parameter on Linux.
> Solaris signature: struct passwd *getpwuid_r(uid_t  uid,  struct  passwd =
 *pwd, char *buffer, int  buflen);=20
> Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf,=
 size_t buflen, struct passwd **result);


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)