zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
Date Sat, 02 May 2015 10:22:06 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525165#comment-14525165
] 

Rakesh R commented on ZOOKEEPER-2174:
-------------------------------------

+1 branch-3.4 patch looks good to me.

> JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated
with an expected exception.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2174
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>             Fix For: 3.4.7, 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-2174-branch-3.4.004.patch, ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch,
ZOOKEEPER-2174.003.patch, ZOOKEEPER-2174.004.patch
>
>
> {{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any exception is thrown,
it logs a message stating that the test failed.  However, some ZooKeeper tests are annotated
with {{@Test(expected=...)}} to indicate that an exception is the expected result, and thus
the test passes.  The runner should be aware of expected exceptions and only log if an unexpected
exception occurs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message