zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raul Gutierrez Segales (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2156) If JAVA_HOME is not set zk startup and fetching status command execution result misleads user.
Date Mon, 18 May 2015 08:40:03 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547728#comment-14547728
] 

Raul Gutierrez Segales commented on ZOOKEEPER-2156:
---------------------------------------------------

lgtm, except for the indentation in this block:

{code}
-  JAVA=java
+echo "Error: JAVA_HOME is not set and java could not be found in PATH." 1>&2
+    exit 1
 fi
{code}

any reason for not indenting that echo statement properly?

> If JAVA_HOME is not set zk startup and fetching status command execution result misleads
user.
> ----------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2156
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2156
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>             Fix For: 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-2156.1.patch, ZOOKEEPER-2156.2.patch, ZOOKEEPER-2156.3.patch,
ZOOKEEPER-2156.4.patch
>
>
> If JAVA_HOME is not set,  zk startup and fetching status command execution result misleads
user.
> 1. Eventhough zk startup has failed since JAVA_HOME is not set , on CLI it displays that
zk STARTED.
> {noformat}
> #:~/Apr3rd/zookeeper-3.4.6/bin> ./zkServer.sh start
> JMX enabled by default
> Using config: /home/REX/Apr3rd/zookeeper-3.4.6/bin/../conf/zoo.cfg
> Starting zookeeper ... STARTED
> {noformat}
> 2.  Fetching zk status when JAVA_HOME is not set displays that process not running .
> {noformat}
> #:~/Apr3rd/zookeeper-3.4.6/bin> ./zkServer.sh status
> JMX enabled by default
> Using config: /home/REX/Apr3rd/zookeeper-3.4.6/bin/../conf/zoo.cfg
> Error contacting service. It is probably not running.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message