zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2096) C client builds with incorrect error codes in VisualStudio 2010+
Date Fri, 01 May 2015 16:43:06 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14523428#comment-14523428
] 

Hadoop QA commented on ZOOKEEPER-2096:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12729772/ZOOKEEPER-2096.patch
  against trunk revision 1676359.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2666//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2666//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2666//console

This message is automatically generated.

> C client builds with incorrect error codes in VisualStudio 2010+
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2096
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2096
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build, c client
>         Environment: Windows MSVS 2010+
>            Reporter: Vitaly Stakhovsky
>         Attachments: ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> It reports:
> warning C4005: 'EWOULDBLOCK' : macro redefinition
> warning C4005: 'EINPROGRESS' : macro redefinition
> In MSVS 2010+, these constants are now in <errno.h>.
> What's worse, they have different numeric values.
> Possible fix:
> In "src/c/include/winconfig.h" :
> #if _MSC_VER < 1600
> #define EWOULDBLOCK WSAEWOULDBLOCK
> #define EINPROGRESS WSAEINPROGRESS
> #endif



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message