zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rakesh R" <rake...@huawei.com>
Subject Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc
Date Tue, 19 May 2015 12:26:25 GMT


> On May 6, 2015, 9:22 a.m., Rakesh R wrote:
> > src/java/test/org/apache/zookeeper/server/CreateContainerTest.java, line 90
> > <https://reviews.apache.org/r/33713/diff/1/?file=946063#file946063line90>
> >
> >     Can we think of some better logic instead of Thread.sleep(1000) in tests. It
may be flaky in some env, right?
> 
> Jordan Zimmerman wrote:
>     I have no other idea. A record is added into ZK's processor and there are no testing
hooks for that. I need to wait for it to get processed. If you have a suggestion, please let
me know. NOTE: ZK's own tests have these timers.

Yes, this we can put on hold. Right now, am not getting any idea.


> On May 6, 2015, 9:22 a.m., Rakesh R wrote:
> > src/java/test/org/apache/zookeeper/server/CreateContainerTest.java, line 131
> > <https://reviews.apache.org/r/33713/diff/1/?file=946063#file946063line131>
> >
> >     Can we think of some better logic instead of Thread.sleep(1000) in tests. It
may be flaky in some env, right?
> >     
> >     I could see there are few more occurances of Thread.sleep(xx) similar to this,
please do the changes. Thanks!
> 
> Jordan Zimmerman wrote:
>     I have no other idea. A record is added into ZK's processor and there are no testing
hooks for that. I need to wait for it to get processed. If you have a suggestion, please let
me know. NOTE: ZK's own tests have these timers.

Yes, this we can put on hold. Right now, am not getting any idea.


- Rakesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33713/#review82648
-----------------------------------------------------------


On May 16, 2015, 4:18 p.m., Jordan Zimmerman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33713/
> -----------------------------------------------------------
> 
> (Updated May 16, 2015, 4:18 p.m.)
> 
> 
> Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales.
> 
> 
> Bugs: ZOOKEEPER-2163
>     https://issues.apache.org/jira/browse/ZOOKEEPER-2163
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> Introduce new ZNode type: container
> 
> 
> Diffs
> -----
> 
>   src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca 
>   src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e 
>   src/java/main/org/apache/zookeeper/CreateMode.java d87f410 
>   src/java/main/org/apache/zookeeper/MultiTransactionRecord.java ea913b4 
>   src/java/main/org/apache/zookeeper/Op.java 97d3d7b 
>   src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331 
>   src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4 
>   src/java/main/org/apache/zookeeper/cli/CreateCommand.java c6de7c6 
>   src/java/main/org/apache/zookeeper/server/ContainerManager.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 
>   src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 
>   src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 7e3c29f 
>   src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf 
>   src/java/main/org/apache/zookeeper/server/Request.java bed9b13 
>   src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0 
>   src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java cf0900b 
>   src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 4d061f4

>   src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 6434d02

>   src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 36a23ee

>   src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java a49319c

>   src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e 
>   src/java/test/org/apache/zookeeper/server/CreateContainerTest.java PRE-CREATION 
>   src/java/test/org/apache/zookeeper/test/CreateModeTest.java 9db01bb 
>   src/zookeeper.jute 709e935 
> 
> Diff: https://reviews.apache.org/r/33713/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jordan Zimmerman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message