zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jordan Zimmerman" <jor...@jordanzimmerman.com>
Subject Re: Review Request 33713: ZOOKEEPER-2163 - Complete implementation and doc
Date Wed, 06 May 2015 17:29:12 GMT


> On May 6, 2015, 9:22 a.m., Rakesh R wrote:
> > src/java/main/org/apache/zookeeper/ZooKeeper.java, line 1404
> > <https://reviews.apache.org/r/33713/diff/1/?file=946048#file946048line1404>
> >
> >     One general thought:
> >     
> >     Instead of providing a new API for creating the container, can we think of "CreateMode.CONTAINER"
a new znode type? Also, I feel this may help us to support multiTxn/batch apis.
> >     
> >     I haven't done detailed analysis, this is just a rough thought that comes in
my mind.

At this point, I don't remember why I chose to add a new API. Other committers haven't asked
for this. But, if you like I can change it a new CreateMode. Supporting multi/trans is a good
point. Please advise.


> On May 6, 2015, 9:22 a.m., Rakesh R wrote:
> > src/java/main/org/apache/zookeeper/server/ContainerManager.java, line 132
> > <https://reviews.apache.org/r/33713/diff/1/?file=946049#file946049line132>
> >
> >     Could you please tell me the reson for the checks
> >     node.stat.getCversion() > 0 ?
> >     
> >     Probably you can add a comment over there, so that others also will understand.

It's to keep newly created containers from being deleted before any children have been added.
If you were to create the container just before a container cleaning period the container
would be immediately be deleted. However, we could change to only deleting a container once
it's n ticks old. Thoughts?


- Jordan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33713/#review82648
-----------------------------------------------------------


On April 30, 2015, 4:08 p.m., Jordan Zimmerman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33713/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 4:08 p.m.)
> 
> 
> Review request for zookeeper, michim, Rakesh R, and Raul Gutierrez Segales.
> 
> 
> Bugs: ZOOKEEPER-2163
>     https://issues.apache.org/jira/browse/ZOOKEEPER-2163
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> Introduce new ZNode type: container
> 
> 
> Diffs
> -----
> 
>   CHANGES.txt 51ec65d 
>   bin/zkServer.sh dae3ce2 
>   src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml c12c2ca 
>   src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml 223cf8e 
>   src/java/main/org/apache/zookeeper/ZooDefs.java a4fc331 
>   src/java/main/org/apache/zookeeper/ZooKeeper.java dd8ecf4 
>   src/java/main/org/apache/zookeeper/server/ContainerManager.java PRE-CREATION 
>   src/java/main/org/apache/zookeeper/server/DataNode.java b341a69 
>   src/java/main/org/apache/zookeeper/server/DataTree.java 78cddb1 
>   src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 7e3c29f 
>   src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 4911acf 
>   src/java/main/org/apache/zookeeper/server/Request.java bed9b13 
>   src/java/main/org/apache/zookeeper/server/TraceFormatter.java 582383d 
>   src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 63daea0 
>   src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java cf0900b 
>   src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 4d061f4

>   src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 6434d02

>   src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 36a23ee

>   src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java a49319c

>   src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1a45c5e 
>   src/java/test/org/apache/zookeeper/server/CreateContainerTest.java PRE-CREATION 
>   src/zookeeper.jute 709e935 
> 
> Diff: https://reviews.apache.org/r/33713/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jordan Zimmerman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message