Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Sun, 10 Nov 2013 08:19:17 +0000 (UTC)
From: =?utf-8?Q?Germ=C3=A1n_Blanco_=28JIRA=29?= <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.12677608.1383671030153.48180.1384071557860@arcas>
In-Reply-To: <JIRA.12677608.1383671030153@arcas>
References: <JIRA.12677608.1383671030153@arcas>
Subject: [jira] [Commented] (ZOOKEEPER-1808) Add version to FLE
 notifications for 3.4 branch
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
13818397#comment-13818397 ]=20

Germ=C3=A1n Blanco commented on ZOOKEEPER-1808:
------------------------------------------

Unless you change this "if(response.buffer.capacity() =3D=3D 40) {" to "if(=
response.buffer.capacity() >=3D 40) {", it will not be easy to increase the=
 size of the message in the future. That means that the version field will =
have very limited (if any) use, since changing the first 36 bytes of the me=
ssage breaks backwards compatibility with 3.4.5.

> Add version to FLE notifications for 3.4 branch
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-1808
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>             Fix For: 3.4.6
>
>         Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPE=
R-1808.patch, ZOOKEEPER-1808.patch
>
>
> Add version to notification messages so that we can differentiate message=
s during rolling upgrades. This task is for the 3.4 branch only.=20


--
This message was sent by Atlassian JIRA
(v6.1#6144)