Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Mon, 4 Nov 2013 21:28:17 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.12677175.1383348767213.18371.1383600497540@arcas>
In-Reply-To: <JIRA.12677175.1383348767213@arcas>
References: <JIRA.12677175.1383348767213@arcas>
Subject: [jira] [Commented] (ZOOKEEPER-1807) Observers spam each other
 creating connections to the election addr
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
13813294#comment-13813294 ]=20

Hadoop QA commented on ZOOKEEPER-1807:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment=20
  http://issues.apache.org/jira/secure/attachment/12612023/ZOOKEEPER-1807-a=
lex.patch
  against trunk revision 1535491.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modi=
fied tests.
                        Please justify why no new tests are needed for this=
 patch.
                        Also please list what manual steps were performed t=
o verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of java=
c compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.=
3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number=
 of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1742/=
/testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/=
1742//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/174=
2//console

This message is automatically generated.

> Observers spam each other creating connections to the election addr
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1807
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Raul Gutierrez Segales
>            Assignee: Germ=C3=A1n Blanco
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807.patch, not=
ifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open =
connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=3D13]] - There is a co=
nnection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=3D13]] - There is a co=
nnection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=3D13]] - There is a co=
nnection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=3D13]] - There is a co=
nnection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=3D13]] - There is a co=
nnection already for server 14
> {noformat}
> and so and so on ad nauseam.=20
> Now, looking around I found this inside FastLeaderElection.java from when=
 you committed ZOOKEEPER-107:
> {noformat}
>      private void sendNotifications() {
> -        for (QuorumServer server : self.getVotingView().values()) {
> -            long sid =3D server.id;
> -
> +        for (long sid : self.getAllKnownServerIds()) {
> +            QuorumVerifier qv =3D self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try=
 to connect to each other (as opposed as just connecting to participants). =
I'll give it a try now and let you know. (Also, we use observer ids that ar=
e > 0, and I saw some parts of the code that might not deal with that assum=
ption - so it could be that too..).=20


--
This message was sent by Atlassian JIRA
(v6.1#6144)