Return-Path: X-Original-To: apmail-zookeeper-dev-archive@www.apache.org Delivered-To: apmail-zookeeper-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9459C10E11 for ; Tue, 5 Nov 2013 05:03:23 +0000 (UTC) Received: (qmail 57445 invoked by uid 500); 5 Nov 2013 05:03:23 -0000 Delivered-To: apmail-zookeeper-dev-archive@zookeeper.apache.org Received: (qmail 57095 invoked by uid 500); 5 Nov 2013 05:03:20 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 57065 invoked by uid 99); 5 Nov 2013 05:03:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Nov 2013 05:03:18 +0000 Date: Tue, 5 Nov 2013 05:03:17 +0000 (UTC) From: "Hadoop QA (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-1666) Avoid Reverse DNS lookup if the hostname in connection string is literal IP address. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813637#comment-13813637 ] Hadoop QA commented on ZOOKEEPER-1666: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12612093/ZOOKEEPER-1666-34.patch against trunk revision 1538853. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1743//console This message is automatically generated. > Avoid Reverse DNS lookup if the hostname in connection string is literal IP address. > ------------------------------------------------------------------------------------ > > Key: ZOOKEEPER-1666 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1666 > Project: ZooKeeper > Issue Type: Improvement > Components: java client > Reporter: George Cao > Assignee: George Cao > Labels: patch, test > Attachments: ZOOKEEPER-1666-34.patch, ZOOKEEPER-1666.patch, ZOOKEEPER-1666.patch > > > In our ENV, if the InetSocketAddress.getHostName() is called and the host name in the connection string are literal IP address, then the call will trigger a reverse DNS lookup which is very slow. > And in this situation, the host name can simply set as the IP without causing any problem. -- This message was sent by Atlassian JIRA (v6.1#6144)