zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raul Gutierrez Segales (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
Date Thu, 14 Nov 2013 19:37:21 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822806#comment-13822806
] 

Raul Gutierrez Segales commented on ZOOKEEPER-1810:
---------------------------------------------------

Extra newline in:

{noformat}
+public class FLELostMessageTest extends ZKTestCase {
+    protected static final Logger LOG = LoggerFactory.getLogger(FLELostMessageTest.class);
+
+
+    int count;
{noformat}

Super nit in src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java:

{noformat}
+        cnxManagers[0].toSend(0l, FLETestUtils.createMsg(ServerState.FOLLOWING.ordinal(),
0, 0, 1));
{noformat}

if the same Msg is created again and again, can't we just create it once and reuse?

In :
{noformat}
+                            if (LOG.isDebugEnabled()) {
+                                LOG.debug("Receive new notification message. My id = "
+                                        + self.getId());
+                            }
{noformat}

no need for LOG.isDebugEnabled.

> Add version to FLE notifications for trunk
> ------------------------------------------
>
>                 Key: ZOOKEEPER-1810
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810
>             Project: ZooKeeper
>          Issue Type: Sub-task
>    Affects Versions: 3.5.0
>            Reporter: Flavio Junqueira
>            Assignee: Germán Blanco
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch
>
>
> The same as ZOOKEEPER-1808 but for trunk.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message