zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Flavio Junqueira (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1742) "make check" doesn't work on macos
Date Fri, 01 Nov 2013 16:06:18 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13811391#comment-13811391
] 

Flavio Junqueira commented on ZOOKEEPER-1742:
---------------------------------------------

If we disable the tests for on Mac OS, aren't we exposing ourselves to trouble? The tests
are there for a reason, but granted that I can't remember what these tests are doing, so it
is not clear how critical it is that we run them on Mac OS. 

Just so that I understand, trying to fix the tests so that they run on Mac OS would be hard?
They are running on Ubuntu fine now, is it right? 

> "make check" doesn't work on macos
> ----------------------------------
>
>                 Key: ZOOKEEPER-1742
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Benjamin Reed
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch
>
>
> There are two problems I have spotted when running "make check" with the C client. First,
it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc
and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker
options. It complains that "--wrap" is not a valid. I'm not sure how to deal with this one
yet, since I'm not sure why we are using it.  



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message