zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Germán Blanco (JIRA) <j...@apache.org>
Subject [jira] [Updated] (ZOOKEEPER-1742) "make check" doesn't work on macos
Date Sun, 24 Nov 2013 06:04:36 GMT

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1742:
-------------------------------------

    Attachment: ZOOKEEPER-1742-3.4.patch

Silly me, the failure in testAuth doesn't have to do with SASL.
Only for the sake of completeness, here is the patch that runs successfully in branch 3.4
on my macos (it runs 28 single threaded tests and 55 multithreaded tests). However, some of
these failures could be caused by e.g. underlying race conditions and timing issues, so there
could be more failures for others.

QA fails because this is a patch for 3.4.

It seems to me that the test failures on macos should be handled in a separate JIRA, since
they don't seem related with the -wrap option compiler failure. In this JIRA then, there will
be a pending decision on whether to change the wrapping method (from the ld -wrap option to
the macros) so that tests compile on macos.

> "make check" doesn't work on macos
> ----------------------------------
>
>                 Key: ZOOKEEPER-1742
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.5, 3.5.0
>            Reporter: Flavio Junqueira
>            Assignee: Germán Blanco
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch,
ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch,
ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch
>
>
> There are two problems I have spotted when running "make check" with the C client. First,
it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc
and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker
options. It complains that "--wrap" is not a valid. I'm not sure how to deal with this one
yet, since I'm not sure why we are using it.  



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message