zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Germán Blanco (JIRA) <j...@apache.org>
Subject [jira] [Updated] (ZOOKEEPER-1742) "make check" doesn't work on macos
Date Sat, 23 Nov 2013 06:39:35 GMT

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Germán Blanco updated ZOOKEEPER-1742:
-------------------------------------

    Attachment: ZOOKEEPER-1742-3.4.patch

There are some test cases that fail in 3.4.
This patch disables the 4 test cases that fail in 3.4 for macos so that the tests hopefully
run succesfully.
I haven't been able to test testAuth yet, because there is no SASL configured in my machine,
but I think it should work. Note that if testAuth fails, then many other test cases fail after
it for no additional reason.
I personally think that the best option would be to make the release with this cases failing
for macos and figure out what happens in 3.4.6. That sounds better than delaying the release
because of this or disabling test cases that fail. But in case you prefer the "disabling"
option, please try this.

> "make check" doesn't work on macos
> ----------------------------------
>
>                 Key: ZOOKEEPER-1742
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.5, 3.5.0
>            Reporter: Flavio Junqueira
>            Assignee: Germán Blanco
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch,
ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch,
ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch
>
>
> There are two problems I have spotted when running "make check" with the C client. First,
it complains that the sleep call is not defined in two test files: tests/ZooKeeperQuorumServer.cc
and tests/TestReconfigServer.cc. Including unistd.h works. The second problem is with linker
options. It complains that "--wrap" is not a valid. I'm not sure how to deal with this one
yet, since I'm not sure why we are using it.  



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message