Return-Path: X-Original-To: apmail-zookeeper-dev-archive@www.apache.org Delivered-To: apmail-zookeeper-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 405B710664 for ; Tue, 3 Sep 2013 16:36:54 +0000 (UTC) Received: (qmail 72459 invoked by uid 500); 3 Sep 2013 16:36:53 -0000 Delivered-To: apmail-zookeeper-dev-archive@zookeeper.apache.org Received: (qmail 72452 invoked by uid 500); 3 Sep 2013 16:36:53 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 72271 invoked by uid 99); 3 Sep 2013 16:36:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Sep 2013 16:36:52 +0000 Date: Tue, 3 Sep 2013 16:36:52 +0000 (UTC) From: "Patrick Hunt (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Reopened] (ZOOKEEPER-1670) zookeeper should set a default value for SERVER_JVMFLAGS and CLIENT_JVMFLAGS so that memory usage is controlled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reopened ZOOKEEPER-1670: ------------------------------------- Assignee: Flavio Junqueira (was: Arpit Gupta) I think we should revert this change: 1) The original defaults were based on the JVM egonomics. To change things as this patch does, arbitrarily, might cause problems for some folks. If someone wants a specific value for the heap they should just specify it on the command line - I'd be a lot more comfortable if we set the heap only when a user specified a value (it's ok to have specific env settings for this, just shouldn't have a default). 2) Also many folks are already specifying the heap size using the command line "SERVER_JVMFLAGS" parameter. This change will now cause potential problems as the new defaults may override the SERVER_JVMFLAGS settings already in place. > zookeeper should set a default value for SERVER_JVMFLAGS and CLIENT_JVMFLAGS so that memory usage is controlled > --------------------------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-1670 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1670 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.4.5 > Reporter: Arpit Gupta > Assignee: Flavio Junqueira > Fix For: 3.5.0, 3.4.6 > > Attachments: ZOOKEEPER-1670.patch, ZOOKEEPER-1670.patch, ZOOKEEPER-1670.patch, ZOOKEEPER-1670.patch, ZOOKEEPER-1670.patch > > > We noticed this with jdk 1.6 where if no heap size is set the process takes up to 1/4 of mem available on the machine. > More info http://stackoverflow.com/questions/3428251/is-there-a-default-xmx-setting-for-java-1-5 > You can run the following command to see what are the defaults for your machine > {code} > java -XX:+PrintFlagsFinal -version 2>&1 | grep -i -E 'heapsize|permsize|version' > {code} > And we noticed on two different class of machines that this was 1/4th of total memory on the machine. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira