zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1390) some expensive debug code not protected by a check for debug
Date Sat, 11 Feb 2012 08:09:59 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206052#comment-13206052

Benjamin Reed commented on ZOOKEEPER-1390:

that's a good point camille. i thought it looked kind of ugly scattering all the if(...) around
the code, but the debug messages, do look better than the rather raw looking messages you
get from the toString() methods of the txnhdr and txn. i also don't have a strong opinion,
so i'd like to leave as is, but if anyone feels strongly the other way, i'm fine spinning
a new patch.
> some expensive debug code not protected by a check for debug
> ------------------------------------------------------------
>                 Key: ZOOKEEPER-1390
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1390
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Benjamin Reed
>             Fix For: 3.5.0
>         Attachments: ZOOKEEPER-1390.patch
> there is some expensive debug code in DataTree.processTxn() that formats transactions
for debugging that are very expensive but are only used when errors happen and when debugging
is turned on.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message