Return-Path: X-Original-To: apmail-zookeeper-dev-archive@www.apache.org Delivered-To: apmail-zookeeper-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8E69A883B for ; Tue, 30 Aug 2011 08:43:07 +0000 (UTC) Received: (qmail 54880 invoked by uid 500); 30 Aug 2011 08:43:07 -0000 Delivered-To: apmail-zookeeper-dev-archive@zookeeper.apache.org Received: (qmail 54440 invoked by uid 500); 30 Aug 2011 08:43:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 54418 invoked by uid 99); 30 Aug 2011 08:43:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Aug 2011 08:43:02 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Aug 2011 08:42:59 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 7243B8E275 for ; Tue, 30 Aug 2011 08:42:38 +0000 (UTC) Date: Tue, 30 Aug 2011 08:42:38 +0000 (UTC) From: "Laxman (JIRA)" To: dev@zookeeper.apache.org Message-ID: <654902848.6802.1314693758464.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (ZOOKEEPER-847) Missing acl check in zookeeper create MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/ZOOKEEPER-847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laxman updated ZOOKEEPER-847: ----------------------------- Attachment: ZOOKEEPER-847.patch > Missing acl check in zookeeper create > ------------------------------------- > > Key: ZOOKEEPER-847 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-847 > Project: ZooKeeper > Issue Type: Bug > Components: java client > Affects Versions: 3.3.1 > Reporter: Patrick Datko > Assignee: Laxman > Attachments: ZOOKEEPER-847.patch > > > I watched the source of the zookeeper class and I missed an acl check in the asynchronous version of the create operation. Is there any reason, that in the asynch version is no > check whether the acl is valid, or did someone forget to implement it. It's interesting because we worked on a refactoring of the zookeeper client and don't want to implement a bug. > The following code is missing: > if (acl != null && acl.size() == 0) { > throw new KeeperException.InvalidACLException(); > } -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira