Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Thu, 11 Aug 2011 04:03:27 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: 
 <1712058984.26635.1313035407366.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-839) deleteRecursive does not belong
 to the other methods
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082895#comment-13082895 ] 

Hadoop QA commented on ZOOKEEPER-839:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12488858/ZOOKEEPER-839.patch
  against trunk revision 1152141.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/440//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/440//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/440//console

This message is automatically generated.

> deleteRecursive does not belong to the other methods
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-839
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-839
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: java client
>    Affects Versions: 3.3.1
>            Reporter: Patrick Datko
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-839.patch
>
>
> DeleteRecursive has been committed to trunk already as a method to the 
> zookeeper class. So in the API it has the same level as the atomic operations 
> create, delete, getData, setData, etc. The user must get the false impression, 
> that deleteRecursive is also an atomic operation.
> It would be better to have deleteRecursive in some helper class but not that 
> deep in zookeeper's core code. Maybe I'd like to have another policy on how to 
> react if deleteRecursive fails in the middle of its work?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira