Return-Path: X-Original-To: apmail-zookeeper-dev-archive@www.apache.org Delivered-To: apmail-zookeeper-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBCFE7C4D for ; Sun, 7 Aug 2011 06:20:02 +0000 (UTC) Received: (qmail 55920 invoked by uid 500); 7 Aug 2011 06:20:02 -0000 Delivered-To: apmail-zookeeper-dev-archive@zookeeper.apache.org Received: (qmail 55653 invoked by uid 500); 7 Aug 2011 06:19:53 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 55611 invoked by uid 99); 7 Aug 2011 06:19:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Aug 2011 06:19:50 +0000 X-ASF-Spam-Status: No, hits=-2000.7 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Aug 2011 06:19:48 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id BB2F3AF8D1 for ; Sun, 7 Aug 2011 06:19:27 +0000 (UTC) Date: Sun, 7 Aug 2011 06:19:27 +0000 (UTC) From: "Benjamin Reed (JIRA)" To: dev@zookeeper.apache.org Message-ID: <1066990547.14557.1312697967763.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (ZOOKEEPER-839) deleteRecursive does not belong to the other methods MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080546#comment-13080546 ] Benjamin Reed commented on ZOOKEEPER-839: ----------------------------------------- +1 i like it mahadev > deleteRecursive does not belong to the other methods > ---------------------------------------------------- > > Key: ZOOKEEPER-839 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-839 > Project: ZooKeeper > Issue Type: Sub-task > Components: java client > Affects Versions: 3.3.1 > Reporter: Patrick Datko > Assignee: Mahadev konar > Priority: Blocker > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-839.patch > > > DeleteRecursive has been committed to trunk already as a method to the > zookeeper class. So in the API it has the same level as the atomic operations > create, delete, getData, setData, etc. The user must get the false impression, > that deleteRecursive is also an atomic operation. > It would be better to have deleteRecursive in some helper class but not that > deep in zookeeper's core code. Maybe I'd like to have another policy on how to > react if deleteRecursive fails in the middle of its work? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira