zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laxman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1140) server shutdown is not stopping threads
Date Fri, 19 Aug 2011 12:26:27 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087677#comment-13087677
] 

Laxman commented on ZOOKEEPER-1140:
-----------------------------------

{quote}
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}

This fix doesn't include any new functionality. Fixes the thread leaks for which I'm not able
to automate a testcase. 

Manually verified the QuorumZxidSyncTest and checked the thread dumps to see any leaks in
debug mode. All the thread leaks noticed were fixed with this patch.

> server shutdown is not stopping threads
> ---------------------------------------
>
>                 Key: ZOOKEEPER-1140
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1140
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>    Affects Versions: 3.4.0
>            Reporter: Patrick Hunt
>            Assignee: Laxman
>            Priority: Blocker
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1140.patch
>
>
> Near the end of QuorumZxidSyncTest there are tons of threads running - 115 "ProcessThread"
threads, similar numbers of SessionTracker.
> Also I see ~100 ReadOnlyRequestProcessor - why is this running as a separate thread?
(henry/flavio?)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message