zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laxman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1140) server shutdown is not stopping threads
Date Wed, 10 Aug 2011 09:36:27 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082253#comment-13082253
] 

Laxman commented on ZOOKEEPER-1140:
-----------------------------------

Two leaks has been identified.

1) SendThread is getting leaked. [LearnerHandler]
*Approach to fix*
a) Add the proposalOfDeath in shutdown() rather in finally block. 

2) ROZK is getting shutdown even before startup.
*Approach to fix*
a) Synchronize the startup and shutdown of ROZK to avoid concurrent startp and shutdown.
b) Add a flag "shutdown" and check in startup to avoid startup after shutdown.
c) Interrupt the thread that is starting ROZK and join on that thread in finally block before
calling shutdown.

Both of these leaks I'm planning to address in my patch as per a/m approach.

Please let me know if you have any different approach or any suggestion.

> server shutdown is not stopping threads
> ---------------------------------------
>
>                 Key: ZOOKEEPER-1140
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1140
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server, tests
>    Affects Versions: 3.4.0
>            Reporter: Patrick Hunt
>            Assignee: Laxman
>            Priority: Blocker
>             Fix For: 3.4.0
>
>
> Near the end of QuorumZxidSyncTest there are tons of threads running - 115 "ProcessThread"
threads, similar numbers of SessionTracker.
> Also I see ~100 ReadOnlyRequestProcessor - why is this running as a separate thread?
(henry/flavio?)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message