zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-839) deleteRecursive does not belong to the other methods
Date Mon, 15 Aug 2011 10:55:32 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085028#comment-13085028
] 

Hudson commented on ZOOKEEPER-839:
----------------------------------

Integrated in ZooKeeper-trunk #1266 (See [https://builds.apache.org/job/ZooKeeper-trunk/1266/])
    ZOOKEEPER-839. deleteRecursive does not belong to the other methods. (mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1157559
Files : 
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/ZooKeeperTest.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZKUtil.java
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java


> deleteRecursive does not belong to the other methods
> ----------------------------------------------------
>
>                 Key: ZOOKEEPER-839
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-839
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: java client
>    Affects Versions: 3.3.1
>            Reporter: Patrick Datko
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-839.patch
>
>
> DeleteRecursive has been committed to trunk already as a method to the 
> zookeeper class. So in the API it has the same level as the atomic operations 
> create, delete, getData, setData, etc. The user must get the false impression, 
> that deleteRecursive is also an atomic operation.
> It would be better to have deleteRecursive in some helper class but not that 
> deep in zookeeper's core code. Maybe I'd like to have another policy on how to 
> react if deleteRecursive fails in the middle of its work?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message