zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1060) QuorumPeer takes a long time to shutdown
Date Tue, 10 May 2011 20:03:48 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031342#comment-13031342
] 

Hadoop QA commented on ZOOKEEPER-1060:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12478724/ZOOKEEPER-1060.patch
  against trunk revision 1099329.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/255//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/255//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/255//console

This message is automatically generated.

> QuorumPeer takes a long time to shutdown
> ----------------------------------------
>
>                 Key: ZOOKEEPER-1060
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1060
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum
>    Affects Versions: 3.4.0
>            Reporter: Vishal K
>            Assignee: Vishal K
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1060.patch
>
>
> This problem is seen only if you have ZooKeeper embedded in your application. QuorumPeerMain.initializeAndRun()
does a quorumPeer.join() before exiting.
> QuorumPeer.shutdown() tries to cleanup everything, but it does not interrupt itself.
As a result, a if the peer is running FLE, it might be waiting to receive notifications (recvqueue.poll())
in FastLeaderElection. Therefore, quorumPeer.join() will wait until the peer wakes up from
poll().
> The fix is simple - call this.interrupt() in QuorumPeer.shutdown().

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message