Return-Path: Delivered-To: apmail-zookeeper-dev-archive@www.apache.org Received: (qmail 85389 invoked from network); 24 Jan 2011 17:46:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Jan 2011 17:46:25 -0000 Received: (qmail 79604 invoked by uid 500); 24 Jan 2011 17:46:25 -0000 Delivered-To: apmail-zookeeper-dev-archive@zookeeper.apache.org Received: (qmail 79378 invoked by uid 500); 24 Jan 2011 17:46:21 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 79367 invoked by uid 99); 24 Jan 2011 17:46:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jan 2011 17:46:20 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=10.0 tests=ALL_TRUSTED,HTML_MESSAGE X-Spam-Check-By: apache.org Received: from [140.211.11.40] (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jan 2011 17:46:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id p0OHjXqs011877; Mon, 24 Jan 2011 17:45:33 GMT Content-Type: multipart/alternative; boundary="===============8596073493896017906==" MIME-Version: 1.0 Subject: Re: Review Request: ZOOKEEPER-465: Ledger size in bytes From: "Benjamin Reed" To: "Dhruba Borthakur" , "Benjamin Reed" Date: Mon, 24 Jan 2011 17:45:33 -0000 Message-ID: <20110124174533.31569.22328@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/234/ Cc: fpj@apache.org, "zookeeper" In-Reply-To: <20110107155244.9300.60224@reviews.apache.org> References: <20110107155244.9300.60224@reviews.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org --===============8596073493896017906== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/234/#review148 ----------------------------------------------------------- trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerEn= try.java does this variable get used? i can't find where. trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerMe= tadata.java isn't this supposed to be length +=3D delta? (why didn't the test case = catch it?) trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRe= coveryOp.java you need to comment why you are doing the subtraction here. = trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/PendingR= eadOp.java we should be using the METADATA_LENGTH here right? - Benjamin On 2011-01-07 07:52:44, fpj wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/234/ > ----------------------------------------------------------- > = > (Updated 2011-01-07 07:52:44) > = > = > Review request for zookeeper, Dhruba Borthakur and Benjamin Reed. > = > = > Summary > ------- > = > It is currently easy to know how many entries a ledger has, but there is = no easy way to know the total number of bytes in a ledger. The idea of this= jira is to add a method that gives the number of bytes in a closed ledger.= My current idea is to simply have the writer counting the number of bytes = written and store it to ZooKeeper. It is currently easy to know how many en= tries a ledger has, but there is no easy way to know the total number of by= tes in a ledger. The idea of this jira is to add a method that gives the nu= mber of bytes in a closed ledger. My current idea is to simply have the wri= ter counting the number of bytes written and store it to ZooKeeper. = > = > = > Diffs > ----- > = > trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/Dige= stManager.java 1055984 = > trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/Ledg= erEntry.java 1055984 = > trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/Ledg= erHandle.java 1055984 = > trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/Ledg= erMetadata.java 1055984 = > trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/Ledg= erRecoveryOp.java 1055984 = > trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/Pend= ingReadOp.java 1055984 = > trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/tools/BookK= eeperTools.java 1055984 = > trunk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/AsyncLedge= rOpsTest.java 1055984 = > trunk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/BookieRead= WriteTest.java 1055984 = > trunk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/LedgerReco= veryTest.java 1055984 = > = > Diff: https://reviews.apache.org/r/234/diff > = > = > Testing > ------- > = > = > Thanks, > = > fpj > = > --===============8596073493896017906==--