zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed" <br...@yahoo-inc.com>
Subject Re: Review Request: ZOOKEEPER-465: Ledger size in bytes
Date Mon, 24 Jan 2011 17:45:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/234/#review148
-----------------------------------------------------------



trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerEntry.java
<https://reviews.apache.org/r/234/#comment309>

    does this variable get used? i can't find where.



trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerMetadata.java
<https://reviews.apache.org/r/234/#comment306>

    isn't this supposed to be length += delta? (why didn't the test case catch it?)



trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
<https://reviews.apache.org/r/234/#comment308>

    you need to comment why you are doing the subtraction here. 



trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/PendingReadOp.java
<https://reviews.apache.org/r/234/#comment307>

    we should be using the METADATA_LENGTH here right?


- Benjamin


On 2011-01-07 07:52:44, fpj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/234/
> -----------------------------------------------------------
> 
> (Updated 2011-01-07 07:52:44)
> 
> 
> Review request for zookeeper, Dhruba Borthakur and Benjamin Reed.
> 
> 
> Summary
> -------
> 
> It is currently easy to know how many entries a ledger has, but there is no easy way
to know the total number of bytes in a ledger. The idea of this jira is to add a method that
gives the number of bytes in a closed ledger. My current idea is to simply have the writer
counting the number of bytes written and store it to ZooKeeper. It is currently easy to know
how many entries a ledger has, but there is no easy way to know the total number of bytes
in a ledger. The idea of this jira is to add a method that gives the number of bytes in a
closed ledger. My current idea is to simply have the writer counting the number of bytes written
and store it to ZooKeeper. 
> 
> 
> Diffs
> -----
> 
>   trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/DigestManager.java
1055984 
>   trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerEntry.java
1055984 
>   trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerHandle.java
1055984 
>   trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerMetadata.java
1055984 
>   trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/LedgerRecoveryOp.java
1055984 
>   trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/client/PendingReadOp.java
1055984 
>   trunk/src/contrib/bookkeeper/src/java/org/apache/bookkeeper/tools/BookKeeperTools.java
1055984 
>   trunk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java
1055984 
>   trunk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/BookieReadWriteTest.java
1055984 
>   trunk/src/contrib/bookkeeper/test/org/apache/bookkeeper/test/LedgerRecoveryTest.java
1055984 
> 
> Diff: https://reviews.apache.org/r/234/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> fpj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message