zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed" <br...@yahoo-inc.com>
Subject Re: Review Request: ZOOKEEPER-962_3
Date Tue, 18 Jan 2011 22:54:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/333/#review139
-----------------------------------------------------------



trunk/src/java/main/org/apache/zookeeper/server/ZKDatabase.java
<https://reviews.apache.org/r/333/#comment291>

    can we change the comment here? when i first saw it, i thought there was a race condition,
but then i realized that getReadHoldCount() is the read locks held by the current thread.
    
    perhaps
    
    // check to see if this thread already holds a read lock
    
    apart from the the optimization of avoiding a lock, there is also semantic differences
if the call is made with the lock held. i'm wondering if we should always lock and copy, just
to keep the code clear.



trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
<https://reviews.apache.org/r/333/#comment292>

    can you fix the indentation for this block?


- Benjamin


On 2011-01-18 14:40:47, Benjamin Reed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/333/
> -----------------------------------------------------------
> 
> (Updated 2011-01-18 14:40:47)
> 
> 
> Review request for zookeeper.
> 
> 
> Summary
> -------
> 
> ZOOKEEPER-962 leader/follower coherence issue when follower is receiving a DIFF
> 
> also addresses 
> 
> ZOOKEEPER-919 Ephemeral nodes remains in one of ensemble after deliberate SIGKILL
> 
> 
> Diffs
> -----
> 
>   trunk/src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1058127 
>   trunk/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1058127

>   trunk/src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1058127 
>   trunk/src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1058127 
>   trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1058127

>   trunk/src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1058127 
>   trunk/src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java PRE-CREATION

>   trunk/src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1058127 
> 
> Diff: https://reviews.apache.org/r/333/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message