Return-Path: Delivered-To: apmail-hadoop-zookeeper-dev-archive@minotaur.apache.org Received: (qmail 68508 invoked from network); 8 Oct 2009 10:58:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Oct 2009 10:58:56 -0000 Received: (qmail 69243 invoked by uid 500); 8 Oct 2009 10:58:56 -0000 Delivered-To: apmail-hadoop-zookeeper-dev-archive@hadoop.apache.org Received: (qmail 69135 invoked by uid 500); 8 Oct 2009 10:58:56 -0000 Mailing-List: contact zookeeper-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: zookeeper-dev@hadoop.apache.org Delivered-To: mailing list zookeeper-dev@hadoop.apache.org Received: (qmail 69067 invoked by uid 99); 8 Oct 2009 10:58:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Oct 2009 10:58:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Oct 2009 10:58:53 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6D9F9234C052 for ; Thu, 8 Oct 2009 03:58:32 -0700 (PDT) Message-ID: <101415113.1254999512372.JavaMail.jira@brutus> Date: Thu, 8 Oct 2009 03:58:32 -0700 (PDT) From: "Hudson (JIRA)" To: zookeeper-dev@hadoop.apache.org Subject: [jira] Commented: (ZOOKEEPER-542) c-client can spin when server unresponsive In-Reply-To: <1957330969.1254794131258.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/ZOOKEEPER-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763444#action_12763444 ] Hudson commented on ZOOKEEPER-542: ---------------------------------- Integrated in ZooKeeper-trunk #491 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/491/]) . c-client can spin when server unresponsive (Christian Wiedmann via mahadev) > c-client can spin when server unresponsive > ------------------------------------------ > > Key: ZOOKEEPER-542 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-542 > Project: Zookeeper > Issue Type: Bug > Components: c client > Affects Versions: 3.2.0, 3.2.1 > Reporter: Christian Wiedmann > Assignee: Christian Wiedmann > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-542.patch, ZOOKEEPER-542.patch > > > Due to a mismatch between zookeeper_interest() and zookeeper_process(), when the zookeeper server is unresponsive the client can spin when reconnecting to the server. > In particular, zookeeper_interest() adds ZOOKEEPER_WRITE whenever there is data to be sent, but flush_send_queue() only writes the data if the state is ZOO_CONNECTED_STATE. When in ZOO_ASSOCIATING_STATE, this results in spinning. > This probably doesn't affect production, but I had a runaway process in a development deployment that caused performance issues on the node. This is easy to reproduce in a single node environment by doing a kill -STOP on the server and waiting for the session timeout. > Patch to be added. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.