Mailing-List: contact zookeeper-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: zookeeper-dev@hadoop.apache.org
Message-ID: <1361230455.1220907224500.JavaMail.jira@brutus>
Date: Mon, 8 Sep 2008 13:53:44 -0700 (PDT)
From: "Flavio Paiva Junqueira (JIRA)" <jira@apache.org>
To: zookeeper-dev@hadoop.apache.org
Subject: [jira] Commented: (ZOOKEEPER-118) findbugs flagged switch statement
 in followerrequestprocessor.run()
In-Reply-To: <1534040471.1218478124847.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629285#action_12629285 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-118:
--------------------------------------------------

This piece of code seems correct. Sync should be processed along with other quorum operations such as create, but it does require some special code. In this case case, a follower saves the pending sync operations it has received from its clients before forwarding it to the leader. 

> findbugs flagged switch statement in followerrequestprocessor.run()
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-118
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-118
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Flavio Paiva Junqueira
>
> followerrequestprocessor:
> is the case statement for SYNC supposed to fall through?
>                 switch (request.type) {
>                 case OpCode.sync:
>                     zks.pendingSyncs.add(request);
>                 case OpCode.create:
> Please update the docs/code appropriately (if correct note it with comment just after the sync case statement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.