zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Reed (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-38) headers (version+) in log/snap files
Date Thu, 17 Jul 2008 22:03:31 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614540#action_12614540
] 

Benjamin Reed commented on ZOOKEEPER-38:
----------------------------------------

I really like how you pulled the code out of the scattered locations around the source tree.
I wish you would have pulled them into a couple of classes rather than scattering them into
new classes. It seems like it would be really nice to have a Snapshot class and a TxnLog class.
I think classes like SerializeUtils, AsyncSnapshotPolicy, Util, FileLogWriter, FileLogProvider,
FileDBInfo (perhaps others) could be pulled into these classes. I agree with Mahadev that
the extra interfaces seem overkill for the simple requirements of this Jira. The provider
classes are also overkill for this Jira. Perhaps in the future we may need something like
that, but I'd rather wait for the need than try and foresee a solution now.

Mahadev and I will take a crack at collapsing these classes down.

> headers (version+) in log/snap files
> ------------------------------------
>
>                 Key: ZOOKEEPER-38
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Andrew Kornev
>             Fix For: 3.0.0
>
>         Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, ZOOKEEPER-38.patch
>
>
> Moved from SourceForge to Apache.
> http://sourceforge.net/tracker/index.php?func=detail&aid=1961767&group_id=209147&atid=1008547

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message