zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "james strachan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-74) Cleaning/restructuring up Zookeeper server code
Date Thu, 24 Jul 2008 16:15:31 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616518#action_12616518
] 

james strachan commented on ZOOKEEPER-74:
-----------------------------------------

its a very minor thing, but the contributing guide says to use Sun's coding conventions..

http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute

yet lots of the code tends to litter fields in classes in between methods; its sometimes a
bit hard looking at the source to grok what fields are owned by what object. I prefer the
Sun standards where all the fields are at the top as most java folks and apache java projects
do. 

Though good IDE's can kinda work around this though and so I tend to rely on the outline view
in my IDE rather than the source to grok what state a class has :)

> Cleaning/restructuring up Zookeeper server code
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-74
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-74
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.0.0
>
>
> I have been thinking this for a while and find that the zookeeper server code needs some
cleaning up. The server code is a little tricky/confusing to read sometimes gievn that there
is no clearity on ownership of objects. I will put down a proposal for restructuring/cleaning
the code up with javadocs so that the code is easier to understand and develop on. comments
on what you find confusing are welcome on this jira. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message