Mailing-List: contact zookeeper-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: zookeeper-dev@hadoop.apache.org
Message-ID: <1578024673.1214839184990.JavaMail.jira@brutus>
Date: Mon, 30 Jun 2008 08:19:44 -0700 (PDT)
From: "Benjamin Reed (JIRA)" <jira@apache.org>
To: zookeeper-dev@hadoop.apache.org
Subject: [jira] Commented: (ZOOKEEPER-58) Race condition on ClientCnxn.java
In-Reply-To: <1523578928.1214581125214.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609253#action_12609253 ] 

Benjamin Reed commented on ZOOKEEPER-58:
----------------------------------------

+1 Looks good

> Race condition on ClientCnxn.java
> ---------------------------------
>
>                 Key: ZOOKEEPER-58
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-58
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>         Attachments: patch-incoming-race.txt
>
>
> There is a race condition involving the ByteByffer incomingBuffer, a field of ClientCnxn.SendThread. SendThread reads a packet in two steps: first it reads the length of the packet, followed by a read of the packet itself. Each of these steps corresponds to a call to doIO() from the main loop of run(). If there is an exception or the session times out, then it may leave incomingBuffer in an inconsistent state. 
> The attached patch adds code to reset incomingBuffer upon a call to SendThread.cleanup(). This method is called upon an exception on run().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.