zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Kornev (JIRA)" <j...@apache.org>
Subject [jira] Commented: (ZOOKEEPER-28) Incompatible client and server list detection
Date Wed, 11 Jun 2008 21:06:47 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604338#action_12604338
] 

Andrew Kornev commented on ZOOKEEPER-28:
----------------------------------------

Flavio, 

I'm guessing you'd want to modify the client's connection handshake protocol by adding the
server list information to it. Please take a look at the prime_connection() function in zookeeper.c.
This is where the handshake is implemented. There is a theoretical possibility in the case
where the list of zookeeper nodes gets rather long, the send() call would be able to write
the whole marshalled buffer to the socket, which will result in a connection failure (see
lines 850-851 in zookeeper.c).

Also, please make sure to update the unit tests because this change will break some of them
(for example, c\tests\TestZookeeperInit.cc).

On the server side, I'd like to make sure the server implementation is going to be backward
compatible. In other words, the old clients should still be able to connect to the server.


> Incompatible client and server list detection
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-28
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-28
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: c client, java client, server
>            Reporter: Patrick Hunt
>            Assignee: Andrew Kornev
>             Fix For: 3.0.0
>
>
> Moved from SourceForge to Apache.
> http://sourceforge.net/tracker/index.php?func=detail&aid=1937084&group_id=209147&atid=1008547

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message