From commits-return-7742-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Apr 9 12:36:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ABB16180629 for ; Tue, 9 Apr 2019 14:36:20 +0200 (CEST) Received: (qmail 20516 invoked by uid 500); 9 Apr 2019 12:16:42 -0000 Mailing-List: contact commits-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list commits@zookeeper.apache.org Received: (qmail 20505 invoked by uid 99); 9 Apr 2019 12:16:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Apr 2019 12:16:42 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id EDF1680B1B; Tue, 9 Apr 2019 12:36:19 +0000 (UTC) Date: Tue, 09 Apr 2019 12:36:19 +0000 To: "commits@zookeeper.apache.org" Subject: [zookeeper] branch master updated: ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a null pointer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <155481337985.4468.11473697467082238423@gitbox.apache.org> From: andor@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: zookeeper X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 3b93f7671464bef1824288b13ee66dec547bb97e X-Git-Newrev: 9a7cebb96a8fe810fbeea18d911212076424feaa X-Git-Rev: 9a7cebb96a8fe810fbeea18d911212076424feaa X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. andor pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/zookeeper.git The following commit(s) were added to refs/heads/master by this push: new 9a7cebb ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a null pointer 9a7cebb is described below commit 9a7cebb96a8fe810fbeea18d911212076424feaa Author: Steven McDonald AuthorDate: Tue Apr 9 14:36:10 2019 +0200 ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a null pointer I have tried to get set up to verify that tests pass, but I am still seeing numerous test failures when running `ant test` against the unmodified `master` branch, so I cannot validate that this does not cause failures. Since this particular change is only in documentation, it seems unlikely, so I'm raising a PR anyway. Author: Steven McDonald Reviewers: andor@apache.org Closes #884 from stevenjm/ZOOKEEPER-3314 --- .../src/main/java/org/apache/zookeeper/AsyncCallback.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/AsyncCallback.java b/zookeeper-server/src/main/java/org/apache/zookeeper/AsyncCallback.java index a0a0e1f..10f85da 100644 --- a/zookeeper-server/src/main/java/org/apache/zookeeper/AsyncCallback.java +++ b/zookeeper-server/src/main/java/org/apache/zookeeper/AsyncCallback.java @@ -326,9 +326,9 @@ public interface AsyncCallback { *

* On failure, rc is a failure code in * {@link org.apache.zookeeper.KeeperException.Code}. - * All opResults are + * Either opResults is null, or all opResults are * {@link org.apache.zookeeper.OpResult.ErrorResult}. - * All operations will be rollback-ed even if operations + * All operations will be rolled back even if operations * before the failing one were successful. * * @param rc The return code or the result of the call.