From commits-return-7488-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Jan 7 15:34:38 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DBB80180647 for ; Mon, 7 Jan 2019 15:34:37 +0100 (CET) Received: (qmail 22553 invoked by uid 500); 7 Jan 2019 14:34:37 -0000 Mailing-List: contact commits-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list commits@zookeeper.apache.org Received: (qmail 22541 invoked by uid 99); 7 Jan 2019 14:34:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Jan 2019 14:34:37 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 7184E85BA0; Mon, 7 Jan 2019 14:34:36 +0000 (UTC) Date: Mon, 07 Jan 2019 14:34:36 +0000 To: "commits@zookeeper.apache.org" Subject: [zookeeper] branch branch-3.5 updated: ZOOKEEPER-3197: Improve documentation in ZooKeeperServer.superSecret MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <154687167634.2424.15801056217564222204@gitbox.apache.org> From: andor@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: zookeeper X-Git-Refname: refs/heads/branch-3.5 X-Git-Reftype: branch X-Git-Oldrev: 7f084215e635cf9e572555ec23c55ddf0e73d6b8 X-Git-Newrev: 58552af97aa89ccf5b0c3e962acbd61303d72e2e X-Git-Rev: 58552af97aa89ccf5b0c3e962acbd61303d72e2e X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. andor pushed a commit to branch branch-3.5 in repository https://gitbox.apache.org/repos/asf/zookeeper.git The following commit(s) were added to refs/heads/branch-3.5 by this push: new 58552af ZOOKEEPER-3197: Improve documentation in ZooKeeperServer.superSecret 58552af is described below commit 58552af97aa89ccf5b0c3e962acbd61303d72e2e Author: Colm O hEigeartaigh AuthorDate: Mon Jan 7 15:34:02 2019 +0100 ZOOKEEPER-3197: Improve documentation in ZooKeeperServer.superSecret Author: Colm O hEigeartaigh Reviewers: andor@apache.org Closes #752 from coheigea/ZOOKEEPER-3197 (cherry picked from commit 36b8711ebfd7ea749d547a52ddcd7d8853931728) Signed-off-by: Andor Molnar --- .../src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java b/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java index eb93478..9e5f891 100644 --- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java +++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java @@ -110,8 +110,10 @@ public class ZooKeeperServer implements SessionExpirer, ServerStats.Provider { } /** - * This is the secret that we use to generate passwords, for the moment it - * is more of a sanity check. + * This is the secret that we use to generate passwords. For the moment, + * it's more of a checksum that's used in reconnection, which carries no + * security weight, and is treated internally as if it carries no + * security weight. */ static final private long superSecret = 0XB3415C00L;