zookeeper-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From an...@apache.org
Subject [zookeeper] branch branch-3.5 updated: ZOOKEEPER-3197: Improve documentation in ZooKeeperServer.superSecret
Date Mon, 07 Jan 2019 14:34:36 GMT
This is an automated email from the ASF dual-hosted git repository.

andor pushed a commit to branch branch-3.5
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/branch-3.5 by this push:
     new 58552af  ZOOKEEPER-3197: Improve documentation in ZooKeeperServer.superSecret
58552af is described below

commit 58552af97aa89ccf5b0c3e962acbd61303d72e2e
Author: Colm O hEigeartaigh <coheigea@apache.org>
AuthorDate: Mon Jan 7 15:34:02 2019 +0100

    ZOOKEEPER-3197: Improve documentation in ZooKeeperServer.superSecret
    
    Author: Colm O hEigeartaigh <coheigea@apache.org>
    
    Reviewers: andor@apache.org
    
    Closes #752 from coheigea/ZOOKEEPER-3197
    
    (cherry picked from commit 36b8711ebfd7ea749d547a52ddcd7d8853931728)
    Signed-off-by: Andor Molnar <andor@apache.org>
---
 .../src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java  | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
b/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
index eb93478..9e5f891 100644
--- a/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
+++ b/zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
@@ -110,8 +110,10 @@ public class ZooKeeperServer implements SessionExpirer, ServerStats.Provider
{
     }
 
     /**
-     * This is the secret that we use to generate passwords, for the moment it
-     * is more of a sanity check.
+     * This is the secret that we use to generate passwords. For the moment,
+     * it's more of a checksum that's used in reconnection, which carries no
+     * security weight, and is treated internally as if it carries no
+     * security weight.
      */
     static final private long superSecret = 0XB3415C00L;
 


Mime
View raw message